Rename noChildren to hasChildren for clarity#599
Open
gioalex07 wants to merge 3 commits intoVREMSoftwareDevelopment:mainfrom
Open
Rename noChildren to hasChildren for clarity#599gioalex07 wants to merge 3 commits intoVREMSoftwareDevelopment:mainfrom
gioalex07 wants to merge 3 commits intoVREMSoftwareDevelopment:mainfrom
Conversation
The property noChildren returned true when children were present, which was semantically misleading. Renamed to hasChildren to match the actual behavior and avoid confusion for future contributors.
Owner
|
Thanks for the contribution.
Please update the PR with real‑device testing details so review can continue. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #599 +/- ##
=========================================
Coverage 97.83% 97.83%
Complexity 975 975
=========================================
Files 121 121
Lines 2581 2581
Branches 211 211
=========================================
Hits 2525 2525
Misses 19 19
Partials 37 37 🚀 New features to boost your workflow:
|
VREMSoftwareDevelopment
added
the
AI assistance used
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The property noChildren returned true when children were present, which was semantically misleading. Renamed to hasChildren to match the actual behavior and avoid confusion for future contributors.
Summary
WiFiDetail.noChildrentohasChildrenfor semantic clarity.noChildrenreturnedtruewhen children were present.What does this implement/fix?
WiFiDetail.ktAccessPointsAdapterGroup.kt(2 call sites)WiFiDetailTest.ktandAccessPointsAdapterGroupTest.ktDoes this close any issues?
How was this tested?